Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compare.py handling of nosetests/pytest output #2661

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Improve compare.py handling of nosetests/pytest output #2661

merged 1 commit into from
Dec 9, 2022

Conversation

jsiirola
Copy link
Member

@jsiirola jsiirola commented Dec 8, 2022

Fixes # .

Summary/Motivation:

This resolves issues when comparing performance results between those generated by nosetests and those generated by pytest.

Changes proposed in this PR:

  • standardize test names when loading and comparing results

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@jsiirola jsiirola requested a review from mrmundt December 8, 2022 19:58
@codecov
Copy link

codecov bot commented Dec 8, 2022 •
edited
Loading

Codecov Report

Base: 87.03% // Head: 87.25% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (57ca6d0) compared to base (da48977).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2661      +/-   ##
==========================================
+ Coverage   87.03%   87.25%   +0.22%     
==========================================
  Files         754      757       +3     
  Lines       84051    86018    +1967     
==========================================
+ Hits        73151    75053    +1902     
- Misses      10900    10965      +65
Flag Coverage Δ
linux 84.50% <ø> (+0.06%) ⬆️
osx 74.95% <ø> (+0.11%) ⬆️
other 84.69% <ø> (+0.06%) ⬆️
win 81.83% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/contrib/cp/repn/docplex_writer.py 92.97% <0.00%> (-3.58%) ⬇️
pyomo/gdp/plugins/fix_disjuncts.py 98.55% <0.00%> (-1.45%) ⬇️
pyomo/core/expr/visitor.py 93.24% <0.00%> (-0.16%) ⬇️
pyomo/common/errors.py 100.00% <0.00%> (ø)
pyomo/contrib/cp/__init__.py 100.00% <0.00%> (ø)
...trib/cp/transform/logical_to_disjunctive_walker.py 95.83% <0.00%> (ø)
pyomo/contrib/cp/plugins.py 100.00% <0.00%> (ø)
...rib/cp/transform/logical_to_disjunctive_program.py 96.55% <0.00%> (ø)
pyomo/core/expr/compare.py 98.27% <0.00%> (+0.03%) ⬆️
pyomo/contrib/gdpopt/solve_discrete_problem.py 78.94% <0.00%> (+0.12%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsiirola jsiirola merged commit 9cc86f1 into Pyomo:main Dec 9, 2022
@jsiirola jsiirola deleted the compare-update branch December 9, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blnicho blnicho blnicho approved these changes

@mrmundt mrmundt Awaiting requested review from mrmundt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsiirola @blnicho